Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup fastapi htmx #8

Merged
merged 55 commits into from
May 15, 2024
Merged

Setup fastapi htmx #8

merged 55 commits into from
May 15, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented May 1, 2024 •
edited
Loading

Description

Here i implemented the basic fastapi setup. this includes:

  • Basic logging
  • Simple Readme
  • Custom exception handelers
  • Custom default response class
  • Vscode setup imrpovements
  • 1 jinja template (to be created more in a new PR)
  • Database migrations (with alembic)
  • SQLMode (1 example model)
  • Tests
  • CI/CD improvements
  • Dependency updates
  • docker-compose with postgres

Resolves #2

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog force-pushed the setup-fastapi-htmx branch 2 times, most recently from 6af5772 to aca3703 Compare May 7, 2024 07:34
@berrydenhartog
Add alembic test version
c94b3e5
@berrydenhartog
Add devcontainer vscode settings for python
b7d42d5
@berrydenhartog
Update vscode settings to improve integration with project
3ca72c2
@berrydenhartog
Update project dependencies and filter warnings for pytest
c95f572
@berrydenhartog
Add codecoverage html and lcov generation to test script
5a9e0bb
@berrydenhartog
Rename database scheme variable
4eece34
@berrydenhartog
Move dockerfile cmd to granian
849ad42
@berrydenhartog
Add logging, masking and exceptions
2bf3467
@berrydenhartog
Add tests for masking, logging and exceptions
63c49a5
@berrydenhartog
Add lcov generation to code coverage
98bf40e
@berrydenhartog
Add favicon
76a2f2e
@berrydenhartog
Fix python3.10 problem with Self type
d03903e
@berrydenhartog
Fix docker build
734c660
@berrydenhartog
Add sonarcloud exclusion of tests and alembic
292cf89
@berrydenhartog
Add package cleaner for github
bca492c
@berrydenhartog
Set correct labels for docker image
8891b87
@berrydenhartog
Add badges for sonarcloud
e5be9ca
@berrydenhartog
Renamed actions
b21bd45
@berrydenhartog
Rename ci to test
4a43a23
@berrydenhartog
Rename middleware
3d94c67
@berrydenhartog
Add exception handler file
451f4e5
@berrydenhartog berrydenhartog added the enhancement New feature or request label May 14, 2024
@berrydenhartog berrydenhartog marked this pull request as ready for review May 14, 2024 11:38
@berrydenhartog berrydenhartog requested a review from a team as a code owner May 14, 2024 11:38
@anneschuth
Copy link
Member

Glanced over most of this and it looks great!

We're not running end-to-end test (including, for instance, docker build steps)?

@berrydenhartog
Copy link
Member Author

berrydenhartog commented May 14, 2024 •
edited
Loading

Glanced over most of this and it looks great!

We're not running end-to-end test (including, for instance, docker build steps)?

Not yet. That will be added in the last PR (when we have the frontend done). docker build is done in the CI step (see .github/ci.yaml)

uittenbroekrobbert
uittenbroekrobbert reviewed May 14, 2024
View reviewed changes
BUILD.md Outdated Show resolved Hide resolved
@anneschuth
Copy link
Member

Right, I saw the build but didn't see it covered in tests. Wouldn't we want to be able to run the whole test suite (including builds) locally as well?

Fine if all this happens in a follow up PR

@berrydenhartog berrydenhartog enabled auto-merge May 14, 2024 13:52
@berrydenhartog
Copy link
Member Author

One part i

Right, I saw the build but didn't see it covered in tests. Wouldn't we want to be able to run the whole test suite (including builds) locally as well?

Fine if all this happens in a follow up PR

i am not sure if i will build it the way you want it. we will see when it is done...

@uittenbroekrobbert
Copy link
Contributor

Compliments on an extremely well setup project @berrydenhartog ! Happy to approve this and continue with more awesome things!

@berrydenhartog berrydenhartog merged commit 1557506 into main May 15, 2024
10 checks passed
@berrydenhartog berrydenhartog deleted the setup-fastapi-htmx branch May 15, 2024 06:58
uittenbroekrobbert added a commit that referenced this pull request Jul 3, 2024
@uittenbroekrobbert
# This is a combination of 9 commits.
d9a2816 
# This is the 1st commit message:

Fix sonar badge

# This is the commit message #2:

Add deployment

# This is the commit message #3:

Add concurrency check

# This is the commit message #4:

Fix CI/CD deployment

# This is the commit message #5:

Add hash to build

# This is the commit message #6:

Inject version into template

# This is the commit message #7:

Fix typo in deployment

# This is the commit message #8:

Bump the allpip group across 1 directory with 5 updates

Bumps the allpip group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [sqlmodel](https://github.com/tiangolo/sqlmodel) | `0.0.18` | `0.0.19` |
| [pydantic](https://github.com/pydantic/pydantic) | `2.7.3` | `2.7.4` |
| [pydantic-settings](https://github.com/pydantic/pydantic-settings) | `2.3.1` | `2.3.3` |
| [ruff](https://github.com/astral-sh/ruff) | `0.4.8` | `0.4.9` |
| [pyright](https://github.com/RobertCraigie/pyright-python) | `1.1.366` | `1.1.367` |



Updates `sqlmodel` from 0.0.18 to 0.0.19
- [Release notes](https://github.com/tiangolo/sqlmodel/releases)
- [Changelog](https://github.com/tiangolo/sqlmodel/blob/main/docs/release-notes.md)
- [Commits](fastapi/sqlmodel@0.0.18...0.0.19)

Updates `pydantic` from 2.7.3 to 2.7.4
- [Release notes](https://github.com/pydantic/pydantic/releases)
- [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md)
- [Commits](pydantic/pydantic@v2.7.3...v2.7.4)

Updates `pydantic-settings` from 2.3.1 to 2.3.3
- [Release notes](https://github.com/pydantic/pydantic-settings/releases)
- [Commits](pydantic/pydantic-settings@v2.3.1...v2.3.3)

Updates `ruff` from 0.4.8 to 0.4.9
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@v0.4.8...v0.4.9)

Updates `pyright` from 1.1.366 to 1.1.367
- [Release notes](https://github.com/RobertCraigie/pyright-python/releases)
- [Commits](RobertCraigie/pyright-python@v1.1.366...v1.1.367)

---
updated-dependencies:
- dependency-name: sqlmodel
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: pydantic
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: pydantic-settings
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: ruff
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: pyright
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: allpip
...

Signed-off-by: dependabot[bot] <[email protected]>
# This is the commit message #9:

Add automerge for dependabot & pre-commit and change CODEOWNERS
uittenbroekrobbert added a commit that referenced this pull request Jul 3, 2024
@uittenbroekrobbert
# This is a combination of 17 commits.
6c7f52f 
# This is the 1st commit message:

Fix sonar badge

# This is the commit message #2:

Add deployment

# This is the commit message #3:

Add concurrency check

# This is the commit message #4:

Fix CI/CD deployment

# This is the commit message #5:

Add hash to build

# This is the commit message #6:

Inject version into template

# This is the commit message #7:

Fix typo in deployment

# This is the commit message #8:

Bump the allpip group across 1 directory with 5 updates

Bumps the allpip group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [sqlmodel](https://github.com/tiangolo/sqlmodel) | `0.0.18` | `0.0.19` |
| [pydantic](https://github.com/pydantic/pydantic) | `2.7.3` | `2.7.4` |
| [pydantic-settings](https://github.com/pydantic/pydantic-settings) | `2.3.1` | `2.3.3` |
| [ruff](https://github.com/astral-sh/ruff) | `0.4.8` | `0.4.9` |
| [pyright](https://github.com/RobertCraigie/pyright-python) | `1.1.366` | `1.1.367` |



Updates `sqlmodel` from 0.0.18 to 0.0.19
- [Release notes](https://github.com/tiangolo/sqlmodel/releases)
- [Changelog](https://github.com/tiangolo/sqlmodel/blob/main/docs/release-notes.md)
- [Commits](fastapi/sqlmodel@0.0.18...0.0.19)

Updates `pydantic` from 2.7.3 to 2.7.4
- [Release notes](https://github.com/pydantic/pydantic/releases)
- [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md)
- [Commits](pydantic/pydantic@v2.7.3...v2.7.4)

Updates `pydantic-settings` from 2.3.1 to 2.3.3
- [Release notes](https://github.com/pydantic/pydantic-settings/releases)
- [Commits](pydantic/pydantic-settings@v2.3.1...v2.3.3)

Updates `ruff` from 0.4.8 to 0.4.9
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@v0.4.8...v0.4.9)

Updates `pyright` from 1.1.366 to 1.1.367
- [Release notes](https://github.com/RobertCraigie/pyright-python/releases)
- [Commits](RobertCraigie/pyright-python@v1.1.366...v1.1.367)

---
updated-dependencies:
- dependency-name: sqlmodel
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: pydantic
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: pydantic-settings
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: ruff
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: allpip
- dependency-name: pyright
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: allpip
...

Signed-off-by: dependabot[bot] <[email protected]>
# This is the commit message #9:

Add automerge for dependabot & pre-commit and change CODEOWNERS

# This is the commit message #10:

Add database schema initialization

# This is the commit message #11:

Update .pre-commit-config.yaml

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.8 → v0.4.9](astral-sh/ruff-pre-commit@v0.4.8...v0.4.9)

# This is the commit message #12:

Fix deployment order

# This is the commit message #13:

Fix deploy tag

# This is the commit message #14:

Fix deployment repo access

# This is the commit message #15:

Fix tag deployments

# This is the commit message #16:

Fix version labeling container

# This is the commit message #17:

Update .pre-commit-config.yaml

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.9 → v0.4.10](astral-sh/ruff-pre-commit@v0.4.9...v0.4.10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MVP for a page with a list of project tasks grouped per status
3 participants
@berrydenhartog @anneschuth @uittenbroekrobbert